TST: Make old tests more performant #55746
Merged
+75
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Oct 28, 2023
•
mroeschke
commented
- Use less data to test the same behavior
- Parameterize test for loops
mroeschke
added
the
Testing
| @pytest.mark.slow | ||
| @pytest.mark.parametrize("df, keys, bins, n, m", binned, ids=ids) |
| expected = DataFrame({"x": range(10**6 + 1)}, dtype="int64") | ||
| size_cutoff = 50 | ||
| with monkeypatch.context(): | ||
| monkeypatch.setattr(libindex, "_SIZE_CUTOFF", size_cutoff) |
There was a problem hiding this comment.
hmm looking at this id actually expect us to cdef _SIZE_CUTOFF for a tiny perf boost. no harm in doing this until then i guess
There was a problem hiding this comment.
As long as there's an accessible Python version to override this too, SGTM.
There was a problem hiding this comment.
i think they're mutually exclusive, but im fine with doing this for the short-to-medium term
|
Looks like tests are passing here so going to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.